Repository navigation
test/behave: run the gpinitsystem scenarios the gpdemo fix unblocked - #2211
Merged
tuhaihe merged 1 commit intoNov 1, 2026
Merged
Conversation
tuhaihe
approved these changes
Oct 29, 2026
Alena0704
reviewed
Oct 29, 2026
MisterRaindrop
force-pushed
the
test/behave-untag-gpdemo-trusted-shell
branch
from
October 29, 2026 12:02
5b21011 to
9ad8d67
Compare
Alena0704
approved these changes
Oct 29, 2026
Alena0704
left a comment
Alena0704
left a comment
Collaborator
There was a problem hiding this comment.
No further issues found. LGTM, with a couple of minor suggestions to clarify the comments.
Alena0704
reviewed
Oct 29, 2026
MisterRaindrop
force-pushed
the
test/behave-untag-gpdemo-trusted-shell
branch
from
October 29, 2026 12:38
9ad8d67 to
8c3cfbe
Compare
Contributor
Author
MisterRaindrop
force-pushed
the
test/behave-untag-gpdemo-trusted-shell
branch
from
October 30, 2026 10:45
8c3cfbe to
4a1b956
Compare
cluster config held a relative TRUSTED_SHELL, so gpinitsystem could not find lalshell from the directory the scenarios run in. apache#2177 made it absolute, so remove those tags. Two of them, the banner scenarios, are tagged @backup_restore_bashrc because they append to ~/.bashrc. before_scenario() returns early for the gpinitsystem feature before it backs ~/.bashrc up, while after_scenario() still restores it, and with no backup to restore it deletes ~/.bashrc. Back it up before that early return. Alena Rybakina found this in review. The mirror port scenario also waits for the gpinitsystem fixes in apache#2178 and keeps its tag until that is merged.
tuhaihe
force-pushed
the
test/behave-untag-gpdemo-trusted-shell
branch
from
October 31, 2026 23:45
4a1b956 to
c8938e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2170 tagged 20 gpinitsystem scenarios
@needs_fixbecausedemo_cluster.shwrote a relativeTRUSTED_SHELL=./lalshellinto the cluster config, so gpinitsystem could not find lalshell from the directory the Behave scenarios run in. #2177 made it absolute and is merged, so this removes those 20 tags. The CI job for gpinitsystem now runs them.The mirror port scenario ("gpinitsystem should create consistent port entry on segments postgresql.conf file") also waits for the gpinitsystem fixes in #2178, so it keeps its tag here; #2178 removes it together with the six other tags pointing at its fixes.
Verification
Ran gpinitsystem.feature as the CI job does (
--tags ~@extended, with the workflow's~@needs_fix) on a Rocky 8 demo cluster:@extended)@extended)#2178 and this PR change neighbouring lines of gpinitsystem.feature, so whichever is merged second needs a rebase.