Repository navigation
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 4.22 #13753 +/- ##
============================================
+ Coverage 17.84% 18.05% +0.20%
- Complexity 16025 16316 +291
============================================
Files 5928 5937 +9
Lines 534457 536806 +2349
Branches 65404 65787 +383
============================================
+ Hits 95388 96909 +1521
- Misses 428239 428808 +569
- Partials 10830 11089 +259
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18740 |
|
@blueorangutan help |
|
@DaanHoogland [SL] I understand these words: "help", "hello", "thanks", "package", "test" Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'shwstppr', 'Damans227', 'vishesh92', 'Pearl1594', 'harikrishna-patnala', 'nvazquez', 'DaanHoogland', 'weizhouapache', 'borisstoyanov', 'vladimirpetrov', 'kiranchavala', 'andrijapanicsb', 'NuxRo', 'rajujith', 'sureshanaparti', 'abh1sar', 'sudo87', 'RosiKyu'] |
|
@blueorangutan test ol10 vmware-80u3 |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol10 mgmt + vmware-80u3) has been kicked to run smoke tests |
|
[SF] Trillian Build Failed (tid-16671) |
|
@blueorangutan test ol9 vmware-80u3 |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol9 mgmt + vmware-80u3) has been kicked to run smoke tests |
|
[SF] Trillian Build Failed (tid-16791) |
Pearl1594
left a comment
Pearl1594
left a comment
There was a problem hiding this comment.
code lgtm. I don't have a test env to test this fix. But it looks pretty straightforward. Thanks @Dogface2k
|
@blueorangutan package |
|
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19155 |
|
@blueorangutan test ol9 vmware-80u3 |
|
@Pearl1594 a [SL] Trillian-Jenkins test job (ol9 mgmt + vmware-80u3) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-16935)
|
250f972 to
ca6706f
Compare
Poll vCenter for named NSX backing port groups using a validated timeout, defaulting to 60 seconds and capped by the VMware operation timeout. Follow each completed sleep with a lookup, including the final sleep, and preserve lookup errors and interruption. Convert typed configuration values before validation. Cover timeout routing, configuration updates and readiness behavior in the existing configuration and VMware test suites. Co-authored-by: dahn <daan.hoogland@gmail.com>
ca6706f to
201ffc7
Compare
Damans227
left a comment
Damans227
left a comment
There was a problem hiding this comment.
thanks @Dogface2k, fix looks right. LGTM
This branch has not been deployed
6 participants
Description
Fixes #13752 by retrying the vCenter lookup while an NSX segment's backing distributed port group becomes visible.
vmware.nsx.dvportgroup.wait.timeout: default 60 seconds, capped by the VMware operation timeout. Zero performs one lookup; negative values are rejected before saving.Testing
Windows 11, Java 17.0.20.1, Maven 3.9.11, VMware 8.0 SDK. The 37-module reactor passed with zero Checkstyle violations and 101 tests passed:
ConfigKeyTest: 8HypervisorHostHelperTest: 46VmwareResourceTest: 47The final-sleep regression fails on the previous implementation and passes with the fix. It covers 25 ms and 2,500 ms budgets, with wake-ups at the deadline and 1 ms late.
testOvfDomRewriterwas excluded after reproducing the same Windows line-ending assertion failure on the previous PR head.Remaining validation
No live NSX/vCenter validation or full repository test suite was run. Delayed visibility and permanent absence still need validation against a real environment.