Skip to content

KVM: Support multi vlan trunk NICs - #14166

Draft
Pearl1594 wants to merge 35 commits into
mainfrom
support-multi-vlan-guestnet
Draft

Pearl1594 wants to merge 35 commits into
mainfrom
support-multi-vlan-guestnet

Rollback IP allocation on trunk nic network association failure

da31dd6
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Oct 20, 2026 in 7m 22s

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 5242 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Combine this catch with the one at line 5240, which has the same body.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYAzTUpHmdrJ_o8Kg9&open=AaEYAzTUpHmdrJ_o8Kg9&pullRequest=14166

Check warning on line 2245 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8Knn&open=AaEYA0ZipHmdrJ_o8Knn&pullRequest=14166

Check warning on line 1653 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8Kjz&open=AaEYA0ZhpHmdrJ_o8Kjz&pullRequest=14166

Check warning on line 1571 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8KjC&open=AaEYA0ZhpHmdrJ_o8KjC&pullRequest=14166

Check warning on line 1745 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8Kkf&open=AaEYA0ZipHmdrJ_o8Kkf&pullRequest=14166

Check warning on line 2042 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8KmF&open=AaEYA0ZipHmdrJ_o8KmF&pullRequest=14166

Check warning on line 687 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0kvpHmdrJ_o8Ko5&open=AaEYA0kvpHmdrJ_o8Ko5&pullRequest=14166

Check warning on line 1531 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8Kir&open=AaEYA0ZhpHmdrJ_o8Kir&pullRequest=14166

Check warning on line 461 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0AKpHmdrJ_o8Khw&open=AaEYA0AKpHmdrJ_o8Khw&pullRequest=14166

Check warning on line 1459 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8KiS&open=AaEYA0ZhpHmdrJ_o8KiS&pullRequest=14166

Check warning on line 1897 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8KlV&open=AaEYA0ZipHmdrJ_o8KlV&pullRequest=14166

Check warning on line 2184 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8KnE&open=AaEYA0ZipHmdrJ_o8KnE&pullRequest=14166

Check warning on line 603 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0kvpHmdrJ_o8Kod&open=AaEYA0kvpHmdrJ_o8Kod&pullRequest=14166

Check warning on line 1460 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8KiT&open=AaEYA0ZhpHmdrJ_o8KiT&pullRequest=14166

Check warning on line 156 in server/src/test/java/com/cloud/network/router/CommandSetupHelperTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0awpHmdrJ_o8KoO&open=AaEYA0awpHmdrJ_o8KoO&pullRequest=14166

Check warning on line 2323 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8KoE&open=AaEYA0ZipHmdrJ_o8KoE&pullRequest=14166

Check warning on line 2733 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "never".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0kvpHmdrJ_o8KpD&open=AaEYA0kvpHmdrJ_o8KpD&pullRequest=14166

Check warning on line 2314 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8KoA&open=AaEYA0ZipHmdrJ_o8KoA&pullRequest=14166

Check warning on line 1496 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8Kil&open=AaEYA0ZhpHmdrJ_o8Kil&pullRequest=14166

Check warning on line 1720 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8KkT&open=AaEYA0ZhpHmdrJ_o8KkT&pullRequest=14166

Check warning on line 697 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0kvpHmdrJ_o8Ko7&open=AaEYA0kvpHmdrJ_o8Ko7&pullRequest=14166

Check warning on line 506 in server/src/test/java/com/cloud/deploy/DeploymentPlanningManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "vmProfile" which hides the field declared at line 159.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0qnpHmdrJ_o8KpY&open=AaEYA0qnpHmdrJ_o8KpY&pullRequest=14166

Check warning on line 1384 in engine/orchestration/src/test/java/com/cloud/vm/VirtualMachineManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYAy4ApHmdrJ_o8KgY&open=AaEYAy4ApHmdrJ_o8KgY&pullRequest=14166

Check warning on line 1766 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8Kko&open=AaEYA0ZipHmdrJ_o8Kko&pullRequest=14166

Check warning on line 1342 in engine/orchestration/src/test/java/com/cloud/vm/VirtualMachineManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYAy4ApHmdrJ_o8Kgb&open=AaEYAy4ApHmdrJ_o8Kgb&pullRequest=14166