Repository navigation
fix: skip coverage grade comment on fork PRs - #14299
Open
PrashantBhanage wants to merge 2 commits into
Open
PrashantBhanage wants to merge 2 commits into
PrashantBhanage wants to merge 2 commits into
Conversation
2 tasks done
Damans227
reviewed
Oct 14, 2026
| const runUrl = `${context.serverUrl}/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}`; | ||
| const marker = '<!-- coverage-grade-bot -->'; | ||
|
|
||
| if (!grade || grade === 'N/A') { |
Collaborator
There was a problem hiding this comment.
when does the grade come through empty here? the script exits before writing it when the report is missing, so this step doesnt run then
Author
There was a problem hiding this comment.
when does the grade come through empty here? the script exits before writing it when the report is missing, so this step doesnt run then
You’re right, the grade is never empty when this step runs. Removed the guard and added the same fork check the Sonar upload step uses, so the comment step is skipped on fork PRs
Damans227
reviewed
Oct 14, 2026
| const marker = '<!-- coverage-grade-bot -->'; | ||
|
|
||
| if (!grade || grade === 'N/A') { | ||
| console.log('Coverage grade not available, skipping comment'); |
Collaborator
There was a problem hiding this comment.
does this fix the 403 from #13490? on a fork PR the grade is there, so posting the comment still fails with the read-only token
PrashantBhanage
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR skips the "Post Coverage Grade Comment on PR" step on fork PRs. On forks the token is read-only, so posting the comment fails with a 403. The step now uses the same condition as the "Upload to SonarQube" step.
It also falls back to
N/Awhen branch coverage is not available.This change was separated from #13490 as requested by @DaanHoogland.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
N/A
How Has This Been Tested?
Checked the diff against
apache:main. Only.github/workflows/sonar-check.ymlchanges. No application code or unit tests were changed.How did you try to break this feature and the system with this change?
On fork PRs the comment step is now skipped, so it no longer tries to post with the read-only token. Fork PRs will not get a coverage comment. On PRs from the main repo the step runs as before.