Repository navigation
docs: explain SQL fixtures that miss Comet expression coverage - #7333
Draft
Abhishek-Mohan wants to merge 1 commit into
Draft
Abhishek-Mohan wants to merge 1 commit into
Abhishek-Mohan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6619. The tolerance-comparison documentation remains separate, so this does not close the issue by itself.
Rationale for this change
A SQL fixture can match Spark's results without exercising the expression its author intended to test. Disabling ConstantFolding does not stop NULL propagation, evaluation over inline VALUES, or Comet's planning-time literal casts. The guide also incorrectly showed binary bit_length using the codegen dispatcher.
What changes are included in this PR?
Update
docs/source/contributor-guide/sql-file-tests.mdto:How are these changes tested?
Documentation only. Checked the examples and claims against the SQL-file parser, runner, expression serdes, coverage tagging, existing fixtures, and Spark optimizer/parser sources.
git diff --checkpasses.Council review
Rounds: 1
All three reviewers were satisfied with the scoped change and found no required fixes. Reviews followed the tstack council workflow at high reasoning effort.
AI assistance: implemented with Claude Opus 5.5 and coordinated with GPT-6 Astra through OpenCode in T3 Code.