Repository navigation
Conversation
Add a public no-arg ResolverImpl constructor and register it in META-INF/services/org.osgi.service.resolver.Resolver, so tools can obtain the resolver without OSGi or a hard reference to the class. Showcase for the proposed OSGi spec change in osgi/org.osgi.service.resolver. No JIRA issue yet. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
If the resolve context provides a FormatterLogger, the resolver redirects its log messages there. Without one, the default logger is used as before. Showcase for osgi/org.osgi.service.resolver#44. Stacked on apache#584. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Showcase for the proposed
ResolveContext.getLogger()in osgi/org.osgi.service.resolver#44.Stacked on #584: the first commit belongs to that PR and disappears once it is merged.
ResolveContext.getLogger()(package version 1.2.0)ContextLogger, which redirects the resolver log messages to theFormatterLoggerof the resolve contextA resolver created through the
ServiceLoader(#584) has no other way to get a logger, which is the motivation for the proposal.