Repository navigation
test(examples): entry-point scenarios for criteria queries with an association path (#16902) - #16907
Merged
Merged
Conversation
…ation path next to an alias, a left join, a service, a connection or a tenant The ten scenarios of #16902 as features in the Hibernate 7 and Hibernate 5 examples: a where query through one path twice and over two paths, a dynamic finder next to a criteria alias, a where subquery on an association, ne and not over a left alias, isNull and isNotNull through a left alias, a fetch join with a null association, a data service @where on an association path, the same association query on the default and a named connection, and an association query under two tenants of a partitioned application. The Hibernate 5 example marks the three that differ from Hibernate 7 as pending features (#16905, #16853), and the Hibernate 7 example the where query on a named connection (#16906). Claude-Session: https://claude.ai/code/session_01Dmki4RzWwreEC2GkkyFnvL
This was referenced Nov 9, 2026
jamesfredley
approved these changes
Nov 9, 2026
jamesfredley
left a comment
Contributor
There was a problem hiding this comment.
The added scenarios check association queries through the entry points the module tests do not reach.
…iteria builder on Hibernate 5 and 7 One path spelled several ways is one join, a dotted createAlias joins the associations before its last one, and an order by an alias-qualified path sorts by that alias through both overloads. Hibernate 5 marks all three pending until the alias fixes of #16890 reach 8.0.x.
jamesfredley
approved these changes
Nov 10, 2026
jamesfredley
left a comment
Contributor
There was a problem hiding this comment.
The added scenarios check association queries through the entry points the module tests do not reach.
borinquenkid
added a commit
that referenced
this pull request
Nov 19, 2026
…as on Hibernate 5 ne no longer returns rows whose value is null on Hibernate 7 (matching Hibernate 5), so a club without a team is left out of ne on a property of a left alias, as on Hibernate 5 (#16905). The scenario merged in #16907 expected the earlier behaviour. Claude-Session: https://claude.ai/code/session_01Dmki4RzWwreEC2GkkyFnvL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ten entry-point scenarios of #16902 as features in the Hibernate 7 and Hibernate 5 examples. Each runs one query through an entry point the module join tests do not reach, with an association path next to an alias, a left join, a service, a connection or a tenant, and names the rows it expects. No production code changes.
#16773 is merged, so the diff is only the scenarios.
QueryEntryPointScenariosSpec(H7gorm, H5grails-hibernate)neandnotover a left alias;isNull/isNotNullthrough a left alias@Whereon an association pathQueryEntryPointServiceSpec(bothgrails-data-service)QueryEntryPointDataSourceSpec(bothgrails-multiple-datasources)QueryEntryPointTenantSpec(bothgrails-partitioned-multi-tenancy)Four features are
@PendingFeature, each with its reason; they fail once the difference is fixed, which is the prompt to remove the mark:duplicate association path, andnethrough a left alias drops a null association (Hibernate 5 and 7 differ on a repeated collection path in a where query, and on ne through a left alias #16905).list(fetch: join)is an inner join (Sort where queries by an association the query filters on #16853).All nine example modules pass their full integration tests;
codeStyleis clean. CI is off (no ci).Refs #16902, #16896
https://claude.ai/code/session_01Dmki4RzWwreEC2GkkyFnvL