Repository navigation
fix(vermeer): reject no-op task submissions - #368
Merged
Merged
Conversation
Return method-not-allowed instead of a false success for task collection POST. Cover versioned and legacy routes and retain authentication filters. Correct task submission and PageRank HTTP examples.
MrJs133
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before → After
Posting to the native task collection returns a success-shaped response without creating a task. Reject that unsupported method with HTTP 405 and
Allow: GET, and direct callers to/api/v1/tasks/create.Keep authentication ahead of method rejection on versioned and legacy routes. Correct native task and PageRank examples, including flat parameters and the singular task-status route.
Validation boundary
The author reports focused Go service tests and red/green rejection regressions; these have not been independently rerun here. No UI assets or large-dataset algorithm acceptance are claimed. Pair the documented behavior with 🔗 Doc #552 and the deployed Vermeer image.
Source: 🔗 org Computer #21.
Visual overview
After authentication, unsupported POST requests to the task collection return HTTP 405 with Allow: GET instead of a success-shaped no-op. Submit through /api/v1/tasks/create and use the returned ID with /api/v1/task/{id} to inspect status. Submission is not computation completion. Interface illustration only, not independent Go-test, large-dataset or RC acceptance.