Repository navigation
refactor(store): let process lifecycle separately from readiness - #3441
Merged
Merged
Conversation
This was referenced Oct 31, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3441 +/- ##
============================================
+ Coverage 57.27% 57.72% +0.45%
+ Complexity 6577 2589 -3988
============================================
Files 776 779 +3
Lines 68881 69103 +222
Branches 9431 9489 +58
============================================
+ Hits 39449 39892 +443
+ Misses 25804 25551 -253
- Partials 3628 3660 +32
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bitflicker64
approved these changes
Oct 31, 2026
bitflicker64
left a comment
bitflicker64
left a comment
Contributor
There was a problem hiding this comment.
Blocking: no. Score: 9/10. Summary: /-/lifecycle reports STARTING, STARTED, STOPPING and UNAVAILABLE from Spring Ready and the lognet gRPC lifecycle as documented, with STOPPING set before ContextClosedListener drains workers, and leaves /-/state unchanged; the new tests run in ServerSuiteTest and pass in CI.
MrJs133
approved these changes
Oct 31, 2026
imbajin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: The operator-set
/-/stateflag could not distinguish a started Store process from one still starting without implying data readiness.After: Add a separate
GET /-/lifecyclesignal based on Spring readiness and gRPC lifecycle; shutdown takes precedence. Keep/-/stateunchanged. STARTED does not establish PD registration, shard recovery, Raft catch-up, or read/write readiness.Source: 🔗 hugegraph/hugegraph #362
Paired documentation: 🔗 apache/hugegraph-doc #555
Validation reported by the author: targeted lifecycle tests and full offline reactor compilation. Live HStore and deployment acceptance remain unverified.
Visual overview
进程生命周期与数据就绪分开：GET /-/lifecycle 只观察 Spring Ready 与 gRPC 状态。STOPPING 优先，其次已停止/终止的 gRPC 报 UNAVAILABLE；STARTED 不证明 PD 注册、分片恢复、Raft 追赶或图读写可用。现有 operator /-/state 不变。旧构建 404 只说明此信号不可用，不能判定 STARTED 或停机。接口依赖对应构建，不是滚动更新安全门；示意图不代表已发布、CI、实站或同一 RC 验收通过。评审核对：2026-10-31。