Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IoTDBPipeMetaIT.testAttributeSyncchecks device attributes immediately afterCREATE PIPE, although schema snapshot transfer and device attribute cache updates are asynchronous. An immediateAlwaysassertion can fail on temporarily inconsistent receiver DataNodes (for example,[1, 1, null]). UseassertDataEventuallyOnEnvto wait for the expected merged attributes.The tree/table lifecycle and protocol tests have seven related assertions with the opposite problem: after stopping a pipe and inserting more sender data,
Eventuallycan pass on the first read of the already established receiver contents, missing later unwanted transfers. Use the existingAlwaysassertions to check that receiver data stays unchanged for the observation period, and replace two fixed five-second sleeps with those checks.Validation
JDK 17, targeted integration cases:
IoTDBPipeMetaIT#testAttributeSync: 1 passed.testLifeCycleLogMode,testLifeCycleFileMode,testLifeCycleHybridMode, andtestReceiverAlreadyHaveTimeSeries: 4 passed.testReceiverAlreadyHaveTimeSeries: 1 passed.doTest: 5 passed.doTest: 5 passed.All 16 selected cases passed across runs, with no failures, errors, or skips. The final protocol run completed
mvn verifysuccessfully; Spotless, Checkstyle, forbidden API, and license checks passed. The protocol checks use reduced JVM heaps and two visible processors to fit local Windows memory limits.