[lahodaj]

Consider code like:

package javaapplication1;

public class JavaApplication1 {

    public static void main(String[] args) {
        String str = switch (args.length) {
            case 0 -> {
                System.err.println("3");
                yield "";
            }
            default -> "";
        };
    }
    
}

Select these lines:

                System.err.println("3");
                yield "";

In the Alt-Enter popup, choose Introduce Method.... This leads to:

    public static void main(String[] args) {
        String s = "GTK-test";
        String str = switch (args.length) {
            case 0 -> {
                method();
            }
            default -> "";
        };
    }

    private static void method() {
        System.err.println("3");
        yield "";
    }

which is obviously wrong - it should be something like:

    public static void main(String[] args) {
        String s = "GTK-test";
        String str = switch (args.length) {
            case 0 -> {
                yield method();
            }
            default -> "";
        };
    }

    private static String method() {
        System.err.println("3");
        return "";
    }

This patch attempts to change the introduce hint to do the correct transformation.

closes #8278

---

PR approval and merge checklist:

1. Was this PR correctly labeled, did the right tests run? When did they run?
2. Is this PR squashed?
3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

[mbien]

would be good to rebase this one. Might be something for early NB 29? (freeze for NB28 is about a week away)

[mbien]

testPatternSwitch1: org.netbeans.api.java.source.gen.SwitchTest might have found something

[mbien]

test sees to have found something. moving to NB32

[dbalek]

Is it intentional to replace an old API change record with the new one?

[dbalek]

Some leftover work?

[matthiasblaesing]

@dbalek @lahodaj this is targetted to NB32. Would you please check if this is still viable for NB32 or should this move to NB33?

[ebarboni]

apichange in the PR that need discussion as per review, moving to next milestone

[dbalek]

Consider the following code snippet:

    public static void main(String[] args) {
        String str = switch (args.length) {
            case 0 -> {
                if (true) {
                    String j = "";
                    yield j;
                }
                yield "";
            }
            default -> "";
        };
    }

Select these lines:

                if (true) {
                    String j = "";
                    yield j;
                }

Introduce Method leads to uncompilable source code, where j remains inside the extracted method:

    public static void main(String[] args) {
        String str = switch (args.length) {
            case 0 -> {
                if (method()) yield j;
                yield "";
            }
            default -> "";
        };
    }

    private static boolean method() {
        if (true) {
            String j = "";
            return true;
        }
        return false;
    }

[lahodaj]

Consider the following code snippet:
...

Thanks. I've tried to fix:
22901e1

we unfortunately cannot do the introduce method in this case, as we would need to different exit types.