Repository navigation
net/arp: Give the unit of the ARP entry ages as 10 seconds. - #21322
Merged
Merged
Conversation
The code converts CONFIG_NET_ARP_MAXAGE and CONFIG_NET_ARP_MAXAGE_UNREACHABLE with SEC2TICK(10 * value): the unit is 10 seconds. The help texts said deciseconds, and the comment in netconfig.h said tenths of seconds, 100 times too small. The example in the same texts (120 is 20 minutes) already used 10 seconds. Correct the texts. The code does not change. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
casaroli
requested review from
masayuki2009,
tmedicci and
xiaoxiang781216
as code owners
November 1, 2026 09:35
github-actions
Bot
added
Area: Networking
xiaoxiang781216
approved these changes
Nov 1, 2026
|
acassis
approved these changes
Nov 1, 2026
casaroli
marked this pull request as draft
November 1, 2026 11:28
casaroli
marked this pull request as ready for review
November 1, 2026 11:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
net/arp/arp_table.cconverts both ARP ages withSEC2TICK(10 * value), so their unit is 10 seconds:The help texts of
CONFIG_NET_ARP_MAXAGEandCONFIG_NET_ARP_MAXAGE_UNREACHABLEsaid deciseconds, and the comment ininclude/nuttx/net/netconfig.hsaid tenths of seconds: 100 times too small. The example in the same texts (120 is 20 minutes) already used 10 seconds.This PR corrects the three texts. The code does not change.
Impact
Text only: the Kconfig help and a header comment. A user who set a value from the old help text gets an age 100 times longer than intended; this PR does not change that value.
Testing
lm3s6965-ek:qemu-flat(withCONFIG_NET_ARP) configures with no Kconfig warnings, and the two options keep their defaults (120 and 1).tools/checkpatch.sh -c -u -m -gpasses.