Repository navigation
Conversation
The default-encoding config rejected BOOLEAN RLE, FLOAT/DOUBLE RLE and FLOAT/DOUBLE GORILLA_V1 even though the encoder/decoder factory supports them, so e.g. Python's set_tsfile_config(double_encoding_type_=RLE) failed with E_NOT_SUPPORT. Align the config's allow-list with the factory (and with Java's TYPE_SUPPORTED_ENCODINGS).
get_datatype_encoding returned PLAIN for TIMESTAMP and BLOB instead of the INT64/STRING slot they share with their base types, so a table-model column of those types read back a wrong default encoding. Align the getter with set_datatype_encoding and get_value_encoder: TIMESTAMP maps to int64 and BLOB maps to string. set_datatype_encoding also silently ignored BLOB, VECTOR and UNKNOWN; it now routes BLOB through the STRING/TEXT slot and rejects VECTOR and UNKNOWN with E_NOT_SUPPORT.
The table model is now the mainstream write model, so the compatibility spec drops its tree-model rows and both completeness tests enumerate only the table model. Coverage is unchanged: every (type, encoding, compression) combination is still generated at all four scales, and the rle_overflow rows are kept.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1070 +/- ##
===========================================
+ Coverage 66.30% 66.31% +0.01%
===========================================
Files 777 777
Lines 56372 56375 +3
Branches 9049 9049
===========================================
+ Hits 37379 37387 +8
+ Misses 17341 17336 -5
Partials 1652 1652 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1068.
What changed
Table model only. The cross-language matrix now exercises only the table
model: the tree-model rows are dropped and both completeness tests
(
specMatchesJavaCapabilities,SpecMatchesCppCapabilities) enumerate onlyModel.TABLE. Type × encoding × compression coverage is unchanged, and therle_overflowrows are kept.Complete the per-datatype encoding config.
set_datatype_encodingaccepts the full set the encoder/decoder factories support: BOOLEAN RLE and
FLOAT/DOUBLE RLE + GORILLA_V1. Previously
set_tsfile_config(float_encoding_type_=RLE)and the DOUBLE equivalent failedwith
E_NOT_SUPPORT.Cover TIMESTAMP and BLOB.
get_datatype_encodingreturnedPLAINforTIMESTAMP and BLOB instead of the INT64/STRING slot they share with their base
types; it now maps TIMESTAMP → INT64 and BLOB → STRING, matching
get_value_encoder.set_datatype_encodingalso routes BLOB through theSTRING/TEXT slot and rejects VECTOR/UNKNOWN with
E_NOT_SUPPORTinstead ofsilently ignoring them.
Testing
CWrapperTest.DatatypeEncodingConfigCoversTimestampAndBlob(new)EncodingCompressionCompatibilityTest.SpecMatchesCppCapabilitiesEncodingCompressionCompatibilityTest.FloatingRleOverflowPagesEncodingCompressionCompatibilityTest#specMatchesJavaCapabilities