Repository navigation
chore(deps): pin dependencies - #7
renovate-appwrite[bot] wants to merge 1 commit into
Conversation
Code review
Pins the PostgreSQL 18 base image and the Go build-stage image to specific digests. The Dockerfile continues to use Note Not approving while a bug finding is open: Keep the digest out of Fix with agent prompt### Issue 1
Dockerfile:1
**Keep the digest out of `PG_MAJOR`**
When the build uses the default argument, this makes `PG_MAJOR` equal to `18@sha256:...`; later references then form invalid package names such as `postgresql-18@sha256:...-pgvector` and a nonexistent configuration path. Builds that pass `PG_MAJOR` explicitly avoid this, but a plain `docker build` using the declared default now fails.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Walkthrough (1)
Reviewed Tip Comment |
| @@ -1,7 +1,7 @@ | |||
| ARG PG_MAJOR=18 | |||
| ARG PG_MAJOR=18@sha256:2ea8630df176ad090ec92136dee850397c5af8781e4bcf2e4162593691c61bbc | |||
There was a problem hiding this comment.
Keep the digest out of PG_MAJOR
When the build uses the default argument, this makes PG_MAJOR equal to 18@sha256:...; later references then form invalid package names such as postgresql-18@sha256:...-pgvector and a nonexistent configuration path. Builds that pass PG_MAJOR explicitly avoid this, but a plain docker build using the declared default now fails.
Prompt To Fix With AI
This is a comment left during a code review.
Path: Dockerfile
Line: 1
Comment:
**Keep the digest out of `PG_MAJOR`**
When the build uses the default argument, this makes `PG_MAJOR` equal to `18@sha256:...`; later references then form invalid package names such as `postgresql-18@sha256:...-pgvector` and a nonexistent configuration path. Builds that pass `PG_MAJOR` explicitly avoid this, but a plain `docker build` using the declared default now fails.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · bug · Reply if this doesn't apply.
44bd9c9 to
c490257
Compare
c490257 to
ed86da3
Compare

This PR contains the following updates:
f18c3d7eb63372Configuration
📅 Schedule: (UTC)
* * * * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate CLI.