Skip to content

chore(deps): pin dependencies - #7

Open
renovate-appwrite[bot] wants to merge 1 commit into
mainfrom
renovate/docker-base-image-digests
Open

renovate-appwrite[bot] wants to merge 1 commit into
mainfrom
renovate/docker-base-image-digests

Conversation

@renovate-appwrite

@renovate-appwrite renovate-appwrite Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

This PR contains the following updates:

Package Type Update Change
golang (source) stage pinDigest → f18c3d7
postgres (source) final pinDigest → eb63372

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • Only on Monday (* * * * 1)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate CLI.

@appwrite

appwrite Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Code review

Commit Status Tier Verdict Details
ed86da3 Reviewed Reviewed 🟡 B · Needs changes before merging 💬 Commented View review

The open finding still applies: a default Docker build passes the digest as part of PG_MAJOR, breaking package installation and configuration-path construction.

Pins the PostgreSQL 18 base image and the Go build-stage image to specific digests. The Dockerfile continues to use PG_MAJOR for PostgreSQL package installation and configuration paths.

Note

Not approving while a bug finding is open: Keep the digest out of PG_MAJOR

Fix with agent prompt
### Issue 1
Dockerfile:1
**Keep the digest out of `PG_MAJOR`**

When the build uses the default argument, this makes `PG_MAJOR` equal to `18@sha256:...`; later references then form invalid package names such as `postgresql-18@sha256:...-pgvector` and a nonexistent configuration path. Builds that pass `PG_MAJOR` explicitly avoid this, but a plain `docker build` using the declared default now fails.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Walkthrough (1)
File Change
Dockerfile Adds digests to the PostgreSQL and Go image references.
Still open from earlier reviews (1)

Reviewed ed86da3

Tip

Comment @appwrite review to re-run, or mention @appwrite with a question.

@appwrite appwrite Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · See the inline comments. Summary

Comment thread Dockerfile Outdated
@@ -1,7 +1,7 @@
ARG PG_MAJOR=18
ARG PG_MAJOR=18@sha256:2ea8630df176ad090ec92136dee850397c5af8781e4bcf2e4162593691c61bbc

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the digest out of PG_MAJOR

When the build uses the default argument, this makes PG_MAJOR equal to 18@sha256:...; later references then form invalid package names such as postgresql-18@sha256:...-pgvector and a nonexistent configuration path. Builds that pass PG_MAJOR explicitly avoid this, but a plain docker build using the declared default now fails.

Prompt To Fix With AI
This is a comment left during a code review.
Path: Dockerfile
Line: 1

Comment:
**Keep the digest out of `PG_MAJOR`**

When the build uses the default argument, this makes `PG_MAJOR` equal to `18@sha256:...`; later references then form invalid package names such as `postgresql-18@sha256:...-pgvector` and a nonexistent configuration path. Builds that pass `PG_MAJOR` explicitly avoid this, but a plain `docker build` using the declared default now fails.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · bug · Reply if this doesn't apply.

@renovate-appwrite
renovate-appwrite Bot force-pushed the renovate/docker-base-image-digests branch 2 times, most recently from 44bd9c9 to c490257 Compare November 19, 2026 06:32
@renovate-appwrite
renovate-appwrite Bot force-pushed the renovate/docker-base-image-digests branch from c490257 to ed86da3 Compare November 20, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants