Repository navigation
docs: track events from handlers, not render logic - #20
Merged
Merged
Conversation
- llms.txt: replace the useAptabase snippet that called trackEvent in the component body with an onPress handler, and add guidance against render/effect tracking. - README: send the updated count (not the stale one) and note where to call trackEvent. - HelloWorldExpoRouter: call init once at module load instead of on every render, drop trackEvent from useEffect, and add a 'Send test event' button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Community feedback found React docs that call
trackEventfrom render logic. React re-renders then get counted as user activity. We're making every SDK's examples track user actions from event handlers, never from a component body oruseEffect. See aptabase/aptabase-js#17 and aptabase/aptabase-com#16.What
llms.txt: theuseAptabaseexample calledtrackEvent("screen_viewed")directly in the component body. It now calls it from anonPresshandler, with a note explaining why.README.mdcountfrom beforesetCount.trackEvent.Aptabase.init, outside any component.examples/HelloWorldExpoRouterinit(...)was called in theRootLayoutbody on every render. It now runs once at module load.trackEventfrom the font-erroruseEffect. The error is still thrown to the Expo Router error boundary.trackEventfrom its handler.🤖 Generated with Claude Code