Repository navigation
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: closes #8659
Summary
Changes
As agreed in #8659 (option 1):
BasePersistenceLayer.configure()only applies the config on its first call, so functions sharing a persistence layer instance silently use the first function'sIdempotencyConfig. It now remembers the settings it applied and emits aPowertoolsUserWarningwhen it's configured again with a config whose settings differ, pointing to one persistence layer per config.event_key_jmespath,payload_validation_jmespath,jmespath_options,raise_on_no_idempotency_key,expires_after_seconds,use_local_cache,local_cache_max_items,hash_function), not on object identity, so@idempotentwithout aconfig(which creates a newIdempotencyConfig()per invocation) doesn't warn.lambda_contextandresponse_hookaren't part of it since they're read per call.IdempotencyConfigoptions table.Tests: one for the differing-config case (warns, first config's settings kept; fails without the change) and one checking that a new config with the same settings doesn't warn.
tests/unit,tests/functional/idempotencyandtests/functional/batchpass on Linux (Python 3.12), plus ruff, mypy, ty, bandit and xenon. The existing idempotency tests also pass with this warning turned into an error, so none of them reconfigure a layer with a different config.User experience
Before: two idempotent functions sharing a persistence layer with different configs silently use the first function's settings, and can return another request's stored response.
After: the same setup emits a
PowertoolsUserWarningtelling you to use a separate persistence layer instance for eachIdempotencyConfig.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.