Repository navigation
fix(parser): pass non-JSON octet-stream payloads to the model in EventBridgeV2Envelope - #8669
Open
alphasafal wants to merge 1 commit into
Open
alphasafal wants to merge 1 commit into
alphasafal wants to merge 1 commit into
Conversation
…tBridgeV2Envelope EventBridgeV2Envelope decoded every application/octet-stream payload with bytes.decode() and parsed the result as JSON, so binary payloads raised UnicodeDecodeError and plain-text payloads failed even with model=bytes. Try JSON first and fall back to the raw bytes, matching the EventBridgeV2Event data class: bytes models get the payload, and any other model raises ValidationError. Closes aws-powertools#8666
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: closes #8666
Summary
Changes
EventBridgeV2Envelope.parseranpayload.decode()on everyapplication/octet-streampayload and handed thestrto_parse, which treats anystras JSON. Only octet-stream payloads that were UTF-8 JSON worked.This change adds
_decode_octet_stream, which triesjson.loadson the bytes and falls back to the raw bytes when the payload isn't JSON (json.loadsraisesValueErrorfor both invalid UTF-8 and invalid JSON):bytesmodel receives the raw payload, matchingEventBridgeV2Event(...).records[...].data.ValidationErrorinstead of a rawUnicodeDecodeError.Octet-stream payloads are no longer passed through
_unwrap_put_events, which keeps today's behaviour for JSON bytes (they were never unwrapped, since_unwrap_put_eventsonly saw astr).Tests added to
tests/unit/parser/_pydantic/test_eventbridge_v2.py:model=bytesreturn the raw bytesValidationErrorAll three fail on
developand pass with this change.tests/unit/parser,tests/unit/data_classesandtests/functional/parserpass (428 tests), andruff format/ruff checkare clean.User experience
Before:
After:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.