Repository navigation
feat: More detailled exception message for users - #1955
Open
linkdotnet wants to merge 1 commit into
Open
linkdotnet wants to merge 1 commit into
linkdotnet wants to merge 1 commit into
Conversation
linkdotnet
force-pushed
the
fix/wait-for-better-messages
branch
from
October 23, 2026 13:01
f170c28 to
32881e4
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The sequence documentation materially misrepresents the implemented timeout behavior and claims fixes that are not present.
No open issues 🎉
What changed in this PR
This PR improves bUnit’s wait-timeout diagnostics by distinguishing checks that never started from checks that started but did not complete.
Changes:
- Adds targeted timeout explanations and troubleshooting guidance.
- Adds regression tests and raises the test assembly’s minimum worker-thread count.
- Includes a sequence-diagram specification and generation receipts.
| File | Description |
|---|---|
| tests/bunit.tests/Extensions/WaitForHelpers/RenderedComponentWaitForHelperExtensions.cs | Tests the new timeout diagnostics. |
| tests/bunit.tests/Assembly.cs | Raises minimum worker threads to reduce test starvation. |
| src/bunit/Extensions/WaitForHelpers/WaitForHelper.cs | Tracks check startup and selects timeout details. |
| src/bunit/Extensions/WaitForHelpers/WaitForFailedException.cs | Defines diagnostic messages and troubleshooting guidance. |
| .archify/sequence-waitfor-races-20261023-140532/waitfor-races.finalize.json | Records diagram validation and generation results. |
| .archify/sequence-waitfor-races-20261023-140532/waitfor-races.finalize-summary.json | Summarizes diagram validation results. |
| .archify/sequence-waitfor-races-20261023-140532/waitfor-races.delivery.json | Records diagram provenance and hashes. |
| .archify/sequence-waitfor-races-20261023-140532/waitfor-races.browser-check.json | Records diagram browser checks. |
| .archify/sequence-waitfor-races-20261023-140532/candidate.json | Defines the wait-helper sequence diagram. |
Review effort: Balanced
linkdotnet
force-pushed
the
fix/wait-for-better-messages
branch
from
October 23, 2026 13:52
32881e4 to
d4f5483
Compare
linkdotnet
force-pushed
the
fix/wait-for-better-messages
branch
from
October 23, 2026 17:02
d4f5483 to
13e32f9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.