Repository navigation
Conversation
Copying stamped wheel outputs into a dist directory currently spawns a Python interpreter per `py_wheel_dist` target. Add `//crates/py_wheel_dist:py_wheel_dist_lib`, register `py_wheel_dist` on `shrubbery`, and route `PyWheelDistDir` through `get_shrubbery_tool`. `get_shrubbery_tool` gains `files_to_run` and `is_rust` so rules can pass the resolved tool straight to `ctx.actions.run` and branch on which implementation resolved.
Collaborator
Author
|
This PR was prepared by an agent under human direction. Review comments are triaged by the human author; agent-drafted replies and changes are reviewed and approved by the author before posting. This is an agent-generated comment unreviewed by the user. |
rickeylev
commented
Nov 16, 2026
Drop the wheel-name validation that the Python tool never had, use argfile's parse_fromfile directly instead of a per-crate flagfile parser, and adopt the USAGE constant, flags module, anyhow errors, and long-only arguments used by the other shrubbery subcommands.
rickeylev
commented
Nov 16, 2026
| executable = toolchain.shrubbery, | ||
| executable = executable, | ||
| # `FilesToRunProvider` to pass to `ctx.actions.run(executable = ...)`. | ||
| files_to_run = executable[DefaultInfo].files_to_run, |
Collaborator
Author
There was a problem hiding this comment.
Why have both executable and files_to_run? The two are equivalent. Prefer files_to_run instead of executable, as its more powerful and flexible.
Comment on lines
+83
to
+84
| # True when resolved from the `shrubbery` toolchain. | ||
| is_rust = True, |
Collaborator
Author
There was a problem hiding this comment.
"is_rust" is slightly misleading: that shrubbery is rust based is an implementation detail. rename this to "from_shrubbery_toolchain" instead
Also: i'm guessing for testing? which is fine, I just want to verify my understanding
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying stamped wheel outputs into a dist directory currently spawns a
Python interpreter per
py_wheel_disttarget.Add
//crates/py_wheel_dist:py_wheel_dist_lib, registerpy_wheel_diston
shrubbery, and routePyWheelDistDirthroughget_shrubbery_tool.get_shrubbery_toolgainsfiles_to_runandis_rustso rules can passthe resolved tool straight to
ctx.actions.runand branch on whichimplementation resolved.
Work towards #4250