Repository navigation
Conversation
Collaborator
Author
|
This PR was prepared by an agent under human direction. Review comments are triaged by the human author; agent-drafted replies and changes are reviewed and approved by the author before posting. This is an agent-generated comment unreviewed by the user. |
Validating `py_test` main files with Python requires an exec Python toolchain even when only checking for `__main__` or test harness usage. Add `ruff_python_ast` and `ruff_python_parser` to `crates/Cargo.toml` (pure Rust, so they build for every target platform) and `//crates/py_test_main_validator:py_test_main_validator_lib` on top of them; register `py_test_main_validator` on `shrubbery` and route `PyValidateTestMain` through `get_shrubbery_tool`, skipping the exec runtime requirement when the Rust tool is active.
rickeylev
force-pushed
the
rickeylev/shrubbery/07-py-test-main-validator
branch
from
November 16, 2026 05:23
aa68b75 to
0954ae6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validating
py_testmain files with Python requires an exec Pythontoolchain even when only checking for
__main__or test harness usage.Add
ruff_python_astandruff_python_parsertocrates/Cargo.toml(pure Rust, so they build for every target platform) and
//crates/py_test_main_validator:py_test_main_validator_libon top ofthem; register
py_test_main_validatoronshrubberyand routePyValidateTestMainthroughget_shrubbery_tool, skipping the execruntime requirement when the Rust tool is active.
Work towards #4250