Repository navigation
Conversation
test_override and test_override_invalid_format test CUDA-specific BNB_CUDA_VERSION behavior but did not mock torch.version.hip. On ROCm hosts, get_cuda_bnb_library_path() sees is_hip=True and checks BNB_ROCM_VERSION instead, causing the CUDA override to be ignored. Patch torch.version.hip to None so these tests exercise the CUDA path regardless of the host platform. Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_overrideandtest_override_invalid_formattest CUDA-specificBNB_CUDA_VERSIONbehavior but didn't mocktorch.version.hipget_cuda_bnb_library_path()seesis_hip=Trueand checksBNB_ROCM_VERSIONinstead, so the CUDA override is silently ignored —test_overridegetslibbitsandbytes_rocm120instead oflibbitsandbytes_cuda110, andtest_override_invalid_formatnever hits the validation pathtorch.version.hiptoNonein both tests, matching the pattern already used bytest_version_selectionandtest_rocm_overrideTest plan
test_cuda_setup_evaluatortests pass on gfx1200 (ROCm 6.3/6.4)Nonewhich matches CUDA's native value, so behavior is identical)