Repository navigation
Conversation
alicefr
requested review from
HarshwardhanPatil07 and
Johan-Liebert1
and removed request for
Johan-Liebert1
November 2, 2026 10:17
Collaborator
Author
|
@Mergifyio backport release-0.2 |
🟠 Waiting for conditions to matchDetails
|
jbtrystram
requested changes
Nov 2, 2026
| ARTIFACTS ?= $(abspath _output/logs) | ||
| VERSION ?= $(shell git describe --tags --always --dirty) | ||
| VERSION ?= dev | ||
| GIT_COMMIT ?= $(shell git rev-parse --short HEAD) |
Collaborator
There was a problem hiding this comment.
IMO this should test if the git worktree is dirty and not print the commit in this case.
Collaborator
There was a problem hiding this comment.
Otherwise you'd print the commit on a build that may be completely unrelated
HarshwardhanPatil07
left a comment
HarshwardhanPatil07
left a comment
Member
There was a problem hiding this comment.
this one will need rebase after this one gets merged, updated the ci timeout
jbtrystram
previously approved these changes
Nov 3, 2026
Johan-Liebert1
previously approved these changes
Nov 3, 2026
Signed-off-by: Alice Frosi <afrosi@redhat.com>
Print the version and the git commit of the binary. E.g: bin/daemon -version 0.2.2 (commit 4660cf252457701bf61320314b03eb00232f07e8) Signed-off-by: Alice Frosi <afrosi@redhat.com>
Signed-off-by: Alice Frosi <afrosi@redhat.com>
alicefr
dismissed stale reviews from Johan-Liebert1 and jbtrystram
via
November 3, 2026 13:09
33354d8
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Print correct version and commit