Repository navigation
fix(pg-protocol): expose severity field V as severityNonLocalized - #3833
Open
princejain756 wants to merge 1 commit into
Open
princejain756 wants to merge 1 commit into
princejain756 wants to merge 1 commit into
Conversation
The V field holds the never-localized severity, while S is translated per lc_messages. The parser already read V into the field map but kept only S, so on a localized server nothing on the error object carried a severity a client could compare (a Russian FATAL arrives as "ВАЖНО"). Errors and notices now expose it beside severity. Fixes brianc#3827
charmander
approved these changes
Oct 23, 2026
Author
|
Thanks for the review, @charmander! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL sends severity twice in
ErrorResponse/NoticeResponse:Slocalized perlc_messages, andVnever localized (9.6+).parseErrorMessagealready readsVinto the field map but drops it, so on a localized server nothing on the error carries a comparable severity - a Russian FATAL arrives asВАЖНО.DatabaseErrorandNoticeMessagenow exposeVasseverityNonLocalized, absent for pre-9.6 servers.severitykeeps its current value so nothing changes for users comparing it today. The name follows libpq'sPG_DIAG_SEVERITY_NONLOCALIZED; happy to rename if you prefer something else.Fixes #3827