Repository navigation
Clean up test suite and package metadata - #88
Merged
Merged
Conversation
Tests: - The IOInterface double is a stub; PHPUnit 13 reports a notice per test for a mock without expectations. - Each test gets its own temp directory, removed through Composer's Filesystem. The old PHP_OS === 'Windows' branch never matched, the value on Windows is WINNT. Metadata: - .gitattributes: drop entries for files that no longer exist (phpcs.xml.dist, psalm.xml), export-ignore tests/, phpcs.xml, .gitignore and .gitattributes. - composer.json: remove the stan-tests and stan-baseline scripts, which call a phpstan.phar and tests/phpstan.neon that do not exist. Add keywords and support. - README: license badge points at LICENSE.txt, install command without the :* constraint.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #88 +/- ##
=========================================
Coverage 82.35% 82.35%
Complexity 48 48
=========================================
Files 1 1
Lines 153 153
=========================================
Hits 126 126
Misses 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #87: the test and metadata parts only, no changes to
src/.Tests
IOInterfacedouble is a stub now. PHPUnit 13 reports one notice per test for a mock without expectations.Filesystem. The oldPHP_OS === 'Windows'branch never matched (the value isWINNT).Metadata and README
.gitattributes: droppedphpcs.xml.distandpsalm.xml(files no longer exist), addedtests/,phpcs.xml,.gitignoreand.gitattributesso they stay out of the dist archive.composer.json: removed thestan-testsandstan-baselinescripts, they call aphpstan.pharand atests/phpstan.neonthat are not there. Addedkeywordsandsupport.LICENSE.txt(the fileLICENSEdoes not exist), install command without the:*constraint.