Repository navigation
docs(weak-node-api): update outdated rationale in README - #489
Draft
kraenhansen wants to merge 3 commits into
Draft
kraenhansen wants to merge 3 commits into
kraenhansen wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README justified
weak-node-apiby a Node-API implementation split between Hermes and the host. That split is gone: Hermes implements Node-API, and the host supplieshermes_napi_hostintegration plus one deliberatenapi_fatal_erroroverride. The rationale now rests on what still holds: addons have no specific Hermes to link against, and runtime injection is what lets the override reach them.Also links nodejs/node#60916 as the better long-term solution, since it would remove the need for this library.
No changeset, matching earlier docs-only package README PRs (#411, #400).
Test plan
next(generate-injector.mts,weak-node-api.tsgenerator,RuntimeNodeApi.hpp,HermesNapiHost.hpp,Logger.cpp,ferric/cmake-rnsources)prettier --check packages/weak-node-api/README.md🤖 Generated with Claude Code