Skip to content

refactor(host): drop the shadowing napi_fatal_error #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kraenhansen wants to merge 4 commits into
base: next
Choose a base branch
from
Draft

refactor(host): drop the shadowing napi_fatal_error #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c2775a
feat(host): log Hermes fatal errors through a fatal handler
kraenhansen Oct 31, 2026
a6516bf
chore: trigger CI with labels
kraenhansen Oct 31, 2026
bd15e1f
refactor(host): drop the shadowing napi_fatal_error
kraenhansen Oct 31, 2026
9634e4b
docs: replace the removed RuntimeNodeApi.cpp in the label example
kraenhansen Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/drop-shadowing-napi-fatal-error.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-native-node-api": patch
---

Drop the host's shadowing `napi_fatal_error` in favor of Hermes' own implementation. Fatal Node-API errors still abort the process, but on Android their message now goes to stderr instead of logcat.
4 changes: 2 additions & 2 deletions .claude/CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ is exactly the case above. **Whenever you open a PR here:**
| `Ferric 🦀` | Ferric Apple triplets build | `packages/ferric`, `packages/ferric-example`, or anything napi-rs/Cargo related |
| `weak-node-api` | weak-node-api tests | `packages/weak-node-api` |

A PR can need more than one label — e.g. a change to `RuntimeNodeApi.cpp`
that alters buffer semantics warrants `Host 🏡` plus `Apple 🍎` and
A PR can need more than one label — e.g. a change to `HermesNapiHost.cpp`
that alters async work semantics warrants `Host 🏡` plus `Apple 🍎` and
`Android 🤖`, since the actual behavior change can only be verified on a
real device.

Expand Down
2 changes: 0 additions & 2 deletions packages/host/android/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ add_library(node-api-host SHARED
../cpp/Logger.cpp
../cpp/CxxNodeApiHostModule.cpp
../cpp/WeakNodeApiInjector.cpp
../cpp/RuntimeNodeApi.cpp
../cpp/RuntimeNodeApi.hpp
../cpp/HermesNapiHost.cpp
../cpp/HermesNapiHost.hpp
)
Expand Down
22 changes: 0 additions & 22 deletions packages/host/cpp/RuntimeNodeApi.cpp
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions packages/host/cpp/RuntimeNodeApi.hpp
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/host/scripts/generate-injector.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ export function generateSource(functions: FunctionDecl[]) {
#include <weak_node_api.hpp>

#include <Logger.hpp>
#include <RuntimeNodeApi.hpp>

#if defined(__APPLE__)
#define WEAK_NODE_API_LIBRARY_NAME "@rpath/weak-node-api.framework/weak-node-api"
Expand Down
Loading