Repository navigation
docs: use ECMAScript modules in README examples - #652
Open
kahirokunn wants to merge 1 commit into
Open
kahirokunn wants to merge 1 commit into
kahirokunn wants to merge 1 commit into
Conversation
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
kahirokunn
marked this pull request as ready for review
August 17, 2026 14:17
Contributor
Author
|
Hi ✋ would you mind taking a look when you have a chance? Thank you 🙏 |
Contributor
|
This pull request is stale because it has been open 30 days with no activity. |
Contributor
Author
|
keep |
Contributor
|
This pull request is stale because it has been open 30 days with no activity. |
Contributor
Author
|
Keep |
Contributor
|
@kahirokunn this isn't a breaking change right? Just docs @shiva look ok to merge? |
Contributor
Author
|
I think it would probably be best to merge this change—which converts the internal code to ECMAScript—first, but it might be okay to merge the documentation first. |
Contributor
Author
|
Thanks for your review 🙏 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Use ESM imports in the README examples.
Description
The examples now use one module style. CommonJS applications can still use
require("cloudevents").