Repository navigation
Add PHP extension config files (Phase 2 of extension config migration) - #1332
Merged
Merged
Conversation
Copy the PHP extension YAML files from binary-builder/internal/php/assets/ to config/extensions/ in this repo. This is Phase 2 of the PHP extension config migration plan (see buildpacks-ci docs/php-extensions-migration-plan.md). These files define which PECL extensions and native modules are compiled into each PHP binary version. Moving them here allows the php-buildpack team to manage extension versions independently of binary-builder. The files are not yet consumed by the CI pipeline — that happens in Phase 3 when the build script is updated to pass --extensions-dir to binary-builder. Until then, binary-builder continues to use its embedded copies (which are byte-identical to these files). Files added: - php8-base-extensions.yml: full extension list for all PHP 8.x - php81-extensions-patch.yml through php85-extensions-patch.yml: per-minor-version overrides (exclusions + additions) - README.md: documents file format, naming convention, and update process
- php81-extensions-patch.yml: remove empty 'exclusions:' key that had no entries. Matches php82/php83 which omit the key entirely. - php84-extensions-patch.yml: add comment explaining why ioncube has md5: nil (binary download, not compiled from source). Matches the comment style used for all other entries in the file. - php85-extensions-patch.yml: same ioncube comment fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Copy PHP extension YAML files from binary-builder to this repo, establishing the php-buildpack as the authoritative source for extension version configuration.
Context
This is Phase 2 of the PHP extension config migration plan. The full migration moves extension version ownership from binary-builder (where configs are embedded via
go:embed) to this repo (where they can be managed independently).Changes
New directory:
config/extensions/containing:php8-base-extensions.ymlphp81-extensions-patch.ymlphp82-extensions-patch.ymlphp83-extensions-patch.ymlphp84-extensions-patch.ymlphp85-extensions-patch.ymlREADME.mdImpact
None. These files are not consumed by any code or CI pipeline yet. The CI pipeline will be updated in Phase 3 (buildpacks-ci PR forthcoming) to pass these files to binary-builder via
--extensions-dirduring PHP builds.Until Phase 3 goes live, binary-builder continues to use its embedded copies (byte-identical to these files).
Migration Plan
--extensions-dirflag to binary-builder--extensions-dir