Repository navigation
fix: Keep checkpoint order for unchanged state values - #2638
Merged
Merged
Conversation
erezrokah
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With checkpoints, setting a key to the value it already had recorded nothing if the key had no pending change. A later value of the key could then reach the stream before the rows of the resolver that set the unchanged value, so the CLI could save a cursor past rows it never received.
SetKeynow records the caller's resources for unchanged values in checkpoint mode, and still skips them when it writes to the backend directly. The same issue was found and fixed in the Python SDK in cloudquery/plugin-sdk-python#419.