Repository navigation
Answer documentSymbol for a notebook, and bump core for the fix - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Java notebook had no document outline: jdtls answers with the method, the client got
[].Everything in the projection hangs off the synthetic
class __Cells, which spans lines nocell owns, and core dropped that node together with its children. Fixed in
codedownio/notebook-language-server-core#12; this picks it up and adds the end-to-end test
against a real jdtls.
The test fails on the old core with
Expected a document symbol tree, got: [].Fixes the document-outline half of codedownio/codedown-languages#134. The workspace/symbol
half was fixed separately by codedownio/codedown-languages#140.