Repository navigation
Conversation
sinha108
force-pushed
the
test/callsite-collision
branch
from
October 30, 2026 00:55
ecb0eb7 to
515c1cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test for #32. The bug was fixed by
988581danda7a103f(in #16): call sites are looked up in an index keyed on the declaring file and the call's start and end, not by scanning every file in the package for the first call at a line:col.The fixture has two calls at the same line:col in sibling files, one inside a method declared away from its receiver type. The test fails on the code before
988581d(HelpX -> right, the #32 symptom) and passes onmain.Closes #32.