Repository navigation
fix: one deploy decision for the documentation, taken with the preview label - #411
Merged
Merged
Conversation
This was referenced Nov 7, 2026
Merged
…w label DocumenterVitepress decided the deploy base during makedocs with push_preview=true hard-coded, so a pull request without the label 'documentation push preview' was built for previews/PR<n> and announced a deployment that deploydocs then refused. make.jl now computes the decision once, with the label, passes it to MarkdownVitepress, and calls deploydocs only when it says to deploy (SITE13). Closes #410 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
v0.11.0 tightens SITE13 with the deploy decision this pull request applies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ocots
force-pushed
the
fix/410-preview-deploy-decision
branch
from
November 7, 2026 14:33
035f30b to
4e7e61e
Compare
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan: one deploy decision for the documentation
Conventions: ct-conventions v0.11.0; ct-agents v0.4.0.
What and why
A pull request labelled
run documentationwithoutdocumentation push previewannounced a deployment that never happened (#410):DocumenterVitepress.MarkdownVitepressdecides the deploy base duringmakedocswithpush_preview=truehard-coded when it is given nodeploy_decision, so the site was built forpreviews/PR<n>, thendeploydocs, which reads the label, refused it.What changes
AGENTS.mdSITE13this way (control-toolbox/ct-conventions#54)docs/make.jldeploy_decisiononce withDocumenter.deploy_folder(…; push_preview),push_previewread fromDOCUMENTER_PUSH_PREVIEW; passes it toMarkdownVitepress; callsdeploydocsonly whendeploy_decision.all_okandbases.txtexists, and says why otherwiseNo behaviour change for a push to
main(deploysdev), a stable tag, or a pull request with the preview label.Verification
Decision computed locally for each event (read-only, nothing deployed):
The pull request with the preview label needs the GitHub API (the PR must come from the same repository), so it is checked here in CI:
run documentationonly (run 42379217136):Bases that will be built: [""], "Skipping deployment: no preview requested (label documentation push preview absent).";documentation push preview(run 42382155802):Bases that will be built: ["previews/PR411"],Deploying: ✔, online at https://control-toolbox.org/OptimalControlProblems.jl/previews/PR411/.Follow-up
SITE13is tightened the same way in ct-conventions v0.11.0 (control-toolbox/ct-conventions#54, #55). One issue per package using DocumenterVitepress: control-toolbox/CTBase.jl#648, control-toolbox/CTModels.jl#517, control-toolbox/CTSolvers.jl#326, control-toolbox/CTFlows.jl#516, control-toolbox/CTLie.jl#81, control-toolbox/OptimalControl.jl#1042.The label
documentation push previewdid not exist in this repository (it does in every other one): created, same color and description.Rebased on
mainafter #408 (conflict indocs/make.jl, the fix reapplied on the new file).Closes #410
🤖 Generated with Claude Code