Repository navigation
Exempt pass,nolog control rules from detection-rule metadata - #4
Merged
Merged
Conversation
The rules/*.conf path instruction and the rule-metadata check told CodeRabbit that every rule needs logdata, severity, paranoia-level, attack-type and capec metadata. Initialization (901), 905, 949, 959, 980, 999 and the PL skipAfter guards carry none of these by design, which produced false findings on 901 initialization rules. Also fix the ID range list: 900xxx is crs-setup.conf, 901xxx is initialization (not IP reputation). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeRabbit flagged new 901 initialization rules for missing
logdata,severity,paranoia-level, attack-type andcapecmetadata, quoting our own instruction that "every rule needs" them.That's wrong for control rules: 901, 905, 949, 959, 980 and 999 contain zero
paranoia-level/tags, and theTX:DETECTION_PARANOIA_LEVEL "@lt N"skipAfter guards (e.g. 942011) carry onlyid,phase,pass,nolog,tag:'OWASP_CRS'andver.rules/*.confpath instruction: full metadata scoped to detection rules (911-944, 950-956); control rules explicitly exempt.Validated with
yamllint -d relaxedandcheck-jsonschemaagainst schema.v2.json.🤖 Generated with Claude Code