Repository navigation
Fix #12: Add warnings-as-errors check: warnings fail the build - #37
Merged
lefticus merged 3 commits intoNov 3, 2026
Conversation
There was no check that compiler warnings fail the build. The new `warnings-as-errors` check searches CMake files (comments stripped) and CI configuration for -Werror, /WX, or COMPILE_WARNING_AS_ERROR / CMAKE_COMPILE_WARNING_AS_ERROR set to a true value, and fails if none is found. Partial or disabling forms (-Werror=<warning>, -Wno-error, /WX:NO, OFF) do not count; the well_configured fixture gains a WARNINGS_AS_ERRORS option to match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 96.75% 96.80% +0.04%
==========================================
Files 29 30 +1
Lines 1018 1032 +14
Branches 80 81 +1
==========================================
+ Hits 985 999 +14
Misses 28 28
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
@leftibot fix merge conflicts |
Contributor
Author
|
✅ leftibot finished addressing the review feedback. |
…check Kept both the warnings-as-errors and cxx-extensions tests and check lists; the colored-output test now expects 7 passing checks. Requested by @lefticus in PR cpp-best-practices#37 review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Addressed review feedback from @lefticus. New commits: |
Member
|
@leftibot fix merge conflicts and get tests up to current standards |
Contributor
Author
|
✅ leftibot finished addressing the review feedback. |
…urrent standards
Resolved conflicts with main's one-test-file-per-check layout: the
warnings-as-errors tests move from tests/test_checks.py (deleted on main)
to tests/checks/test_warnings_as_errors.py and now run in every C/C++
project layout via run_in_every_layout, cover every CI provider, and check
the declared languages. test_cli.py and test_plugins.py take main's
versions, which no longer hard-code the list of checks.
To match the other checks on main, warnings-as-errors now declares
languages=C_FAMILY (so Python and Rust projects skip it; their equivalents
are judged by compiler-warnings) and also reads CMakePresets.json /
CMakeUserPresets.json, including the {"type": ..., "value": ...} form.
Requested by @lefticus in PR cpp-best-practices#37 review.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Addressed review feedback from @lefticus. New commits: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated fix by @leftibot.
What changed
Files
Closes #12
Triggered by @lefticus.