Repository navigation
Conversation
…re ignored The validator had no check for a .gitignore, so projects could commit build directories and other generated files without being flagged. The new `gitignore` check fails when there is no .gitignore and warns, per ecosystem, when it does not ignore the top-level build outputs (build/ or out/ for C/C++, __pycache__/ or *.py[cod] for Python, /target for Rust). The well-configured fixtures now include a .gitignore. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 96.75% 97.03% +0.27%
==========================================
Files 29 30 +1
Lines 1018 1113 +95
Branches 80 91 +11
==========================================
+ Hits 985 1080 +95
Misses 28 28
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
@leftibot add a .gitignore file to this project. Also consider equivalent checks for other source control systems and enhance the check and tests as necessary |
Contributor
Author
|
✅ leftibot finished addressing the review feedback. |
Requested by @lefticus in PR cpp-best-practices#55 review. The check is renamed from `gitignore` to `vcs-ignore` (module vcs_ignore.py) because it now accepts .gitignore, .hgignore, .bzrignore and .fossil-settings/ignore-glob. It fails when none is present, and warns when any present ignore file does not ignore an ecosystem's build outputs. Each file is read in its own syntax: .hgignore regexps (the default), `syntax:` switches and per-entry prefixes; Bazaar RE:, ./, ! and !!; and Fossil's comma or whitespace separated globs. Regular expressions are judged by whether they match the build output paths. Jujutsu uses .gitignore; Subversion keeps svn:ignore in properties, not files, so it cannot be checked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Requested by @lefticus in PR cpp-best-practices#55 review. Ignores Python bytecode and tool caches, virtual environments, packaging outputs and coverage reports, so the project passes its own vcs-ignore check. (The run instructions said not to modify .gitignore, but @lefticus asked for this file explicitly.) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Addressed review feedback from @lefticus. New commits: |
Member
|
@leftibot remove pyc files from this pr branch |
Contributor
Author
|
✅ leftibot finished addressing the review feedback. |
Requested by @lefticus in PR cpp-best-practices#55 review. The compiled __pycache__/*.pyc files were committed on main and this branch had modified them. They are now removed from version control (kept on disk) and remain ignored by the project's .gitignore. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Addressed review feedback from @lefticus. New commits: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated fix by @leftibot.
What changed
Files
Closes #54
Triggered by @lefticus.