Repository navigation
Refactor: Add shared base classes for Cursor and Connection - #842
Open
bgunebakan wants to merge 5 commits into
Open
bgunebakan wants to merge 5 commits into
bgunebakan wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of crate/ecosystem#54.
Summary of the changes / Why this is an improvement
Splits
CursorandConnectioninto a shared base class and the sync class, the planned async client can reuse the parts that do no IO.CursorBaseincrate/client/_cursor_base.pyholds the cursor stateConnectionBaseincrate/client/_connection_base.pyholds the converter and time zone, the closed stateCursorandConnectionkeep all their public methods, signatures and docstrings.This is a pure refactor with no behavior change, and no changelog entry because nothing changes for users.
Two internal details changed, they are not visible from public API.
Cursor.fetchone(),fetchmany()andfetchall()no longer callself.next(), so a subclass that overridesnext()no longer changes them.Connection._closedis now set before the server-version probe instead of after it.Note to reviewer
The PR has 5 commits, and each one passes the tests on its own.
Checklist