Repository navigation
chore(pixels): type the tracker globals for the strict typecheck - #7307
Merged
Merged
Conversation
Touching PixelsContext.tsx put it under typecheck_strict_changed, which failed on the untyped globalThis tracker calls and the seniority lookup with an undefined experience level. Behaviour is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FodmVu1MjgKhW4EZtmBozt
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ido · project thread
Changes
gtag,fbq,twq,rdt,ttq,updateFbUserData) inpackages/webapp/context/PixelsContext.tsxand guards the seniority lookup when there's no experience level.typecheck_strict_changedfailed on its old untypedglobalThiscalls. feat(startups): send Meta InitiateCheckout and Subscribe from the checkout #7306 merged before this fix landed, and the next PR that touches the file would fail the same way.Events
None.
Experiment
None.
Manual Testing
scripts/typecheck-strict-changed.jspasses on the file, webapptscis clean, and oxlint and oxfmt pass.Generated by Claude Code
Preview domain
https://chore-pixels-strict-types.preview.app.daily.dev