Skip to content

fix: preserve CAS callback compatibility and clarify connection checks - #1427

Merged
fit2cloud-chenyw merged 1 commit into
mainfrom
pr@main@fix_cas_url_normalization
Oct 28, 2026
Merged

fit2cloud-chenyw merged 1 commit into
mainfrom
pr@main@fix_cas_url_normalization

Conversation

@fit2cloud-chenyw

Copy link
Copy Markdown
Contributor

CAS callback validation could report both success and failure for the same valid input. Return immediately after successful validation so existing callback values, including root URLs with or without a trailing slash, can be submitted consistently.

Clarify in all five languages that a successful connection check confirms login endpoint reachability; callback and account validation still require an actual sign-in.

Validation:

  • Five Playwright cases passed using the real CAS editor with isolated HTTP boundaries; the duplicate-callback case fails against the original component.
  • Frontend type checking and production build passed on the latest main baseline.
  • Related xpack URL handling and historical service compatibility changes are committed separately in xpack main, version 0.0.5.42; its 36 backend regressions passed. The wheel has not been published.
  • Customer CAS sign-in and persistence are not covered by the component fixture.

@fit2cloud-chenyw

Copy link
Copy Markdown
Contributor Author

LGTM

@fit2cloud-chenyw
fit2cloud-chenyw merged commit 96f06c7 into main Oct 28, 2026
3 checks passed
@fit2cloud-chenyw
fit2cloud-chenyw deleted the pr@main@fix_cas_url_normalization branch October 28, 2026 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant