Repository navigation
fix: apply workflow error policies to failed downloads - #102
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 57 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A workflow download step reports success when a file returns HTTP 404. The download API records the failed file and returns, but
DownloadSteponly reads successful entries. As a result,on_error: faildoes not stop the workflow,continuereports success, andretrynever retries.Check the current step's newly recorded entries and raise when any download failed. The workflow engine can then apply the existing error policy. Standalone download behavior is unchanged.
Type of change
Validation
Six regression cases exercise the real download and workflow code with HTTP responses mocked at the request boundary: fail, continue, and retry, each with and without a workflow manifest. All six fail on the base branch and pass with this change. The retry case also verifies the downloaded file contents.
python -m pytest -q: 189 passed, 3 skipped (Windows, Python 3.13).ruff check .: passed with Ruff 0.5.5.git diff --check: passed.Checklist