Repository navigation
fix: accept UTF-8 signatures in CSV and TSV input - #103
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 56 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
UTF-8 CSV and TSV files with a byte-order mark retain that mark in their first column name. For a
resourceheader, CSV-to-RDF conversion consequently rejects the input as missing its required column.Read tabular input with
utf-8-sigso an optional leading signature is removed. Ordinary UTF-8 input and U+FEFF characters within cell values remain intact.Type of change
Validation
The regression covers CSV and TSV, both with and without a UTF-8 signature. It checks the parsed rows and the resulting RDF triples, including a Unicode value containing an interior U+FEFF. The two signature cases fail before the change; all four pass afterward.
python -m pytest -q: 187 passed, 3 skipped (Windows, Python 3.13).ruff check .: passed with Ruff 0.5.5.git diff --check: passed.Checklist