Repository navigation
Conversation
When message data conversion fails, getCurrentData() invoked onRuleError() which called callback(..., false) and destroy(), but did not return immediately. This allowed run() to continue executing the permission rule with undefined data and invoke callback(..., null, result) a second time, potentially granting permission if the rule evaluated to true. Add missing return statements after onRuleError() in getCurrentData() and crossReference(), add isDestroyed guards in run(), and ensure isReady() returns false once destroyed. Reported-by: BS.ehlas.cz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When message data conversion fails (e.g. malformed JSON payload in
RECORD UPDATE,PATCH,PATCH_MULTI,EVENT, orRPC),getCurrentData()calledthis.onRuleError()which correctly invokedcallback(..., false)and destroyed the application state.However,
getCurrentData()did not return after callingthis.onRuleError(), falling through and returningundefined.run()did not checkthis.isDestroyedafter constructing arguments withgetArguments(), and proceeded to evaluate the permission rule withdata = undefined. If the rule evaluated totrue,run()invokedthis.params.callback(..., null, true)a second time, effectively granting permission despite the earlier parse failure.Changes
returnstatements after callingonRuleError()ingetCurrentData()andcrossReference().if (this.isDestroyed) return;guard checks inrun().isReady()returnsfalseifthis.isDestroyedis true.config-permission-other.spec.tsasserting single-callback denial behavior when message data is unparsable.