Repository navigation
Conversation
onBroadcast looked up receiveStats but stored new maps in sendStats, so deliveries were added to the received counts (or replaced a topic's send counts). sendToSubscribers reported subscribers.size, including the sender's socket that the loop skips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1148
Monitoring stats miscount event broadcasts:
MonitoringBase.onBroadcastlooked upreceiveStatsbut stored new maps insendStats, so deliveries were added toreceived(or replaced a topic's existingsendcounts). It now usessendStatsfor both.DefaultSubscriptionRegistry.sendToSubscribersreportedsubscribers.size, including the sender's socket that the loop below skips. It now reports only the sockets the message is sent to.Tests:
src/services/monitoring/monitoring-base.spec.ts(new): broadcasts count as sent, add to existing send counts on the topic, and counters reset after reading.default-subscription-registry.spec.ts:onBroadcastis called with the number of recipients, excluding the sender.Without the fix the three new assertions fail; with it,
npm testgives 402 passing / 49 pending (398 / 49 before) andnpm run lintis clean, on Node 22.