Repository navigation
fix: rename schema_version overwrite test (#259) - #261
Merged
Merged
Conversation
The #244 test asserted overwrite behavior while claiming the opposite; rename it to overwrites_caller_schema_version.
SaikrishnaGundeti
approved these changes
Oct 31, 2026
SaikrishnaGundeti
left a comment
SaikrishnaGundeti
left a comment
Member
There was a problem hiding this comment.
Approved. Test name now matches the assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
does_not_overwrite_existing_schema_versiontooverwrites_caller_schema_versionso the test name matches the assertion (callerschema_versionis replaced with the contract version)Test plan
cargo fmt --checkcargo clippy --all-features -- -D warningscargo test --all-features --lib json_docFixes #259