Skip to content

fix: plan.not_found hint/next_command; status exits 11 cleanly (#260) - #262

Merged
SaikrishnaGundeti merged 1 commit into
mainfrom
fix/260-plan-not-found-envelope
Oct 31, 2026
Merged

SaikrishnaGundeti merged 1 commit into
mainfrom
fix/260-plan-not-found-envelope

Conversation

@YoungDan

Copy link
Copy Markdown
Member

Summary

  • plan.not_found (exit 11) envelopes now set hint ("check the plan id or list plans") and next_command (deslicer change list)
  • change status propagates plan load failures via the error envelope for both jobs and non-jobs paths — no plain-text stderr line ahead of the JSON document

Test plan

  • cargo fmt --check
  • cargo clippy --all-features -- -D warnings
  • Unit coverage in reporting.rs; network 404 asserts envelope fields
  • change_status covers plan-not-found exit 11 without --jobs

Fixes #260

Fill plan.not_found envelopes with a list-plans hint and next_command, and make change status propagate plan load failures via the JSON error envelope instead of a plain-text stderr preamble.
@YoungDan
YoungDan requested a review from a team as a code owner October 31, 2026 14:59

@SaikrishnaGundeti SaikrishnaGundeti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. plan.not_found now carries hint + next_command, and the non-jobs status path exits 11 via the envelope like --jobs.

@SaikrishnaGundeti
SaikrishnaGundeti merged commit cb5e3f1 into main Oct 31, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plan.not_found envelope has null hint/next_command; change status adds plain-text stderr line

2 participants