Repository navigation
Conversation
The StyleX migration page now says that Devup UI has no StyleX styleResolution option and follows only the default policy, and what that means for shorthands and longhands. It also marks include() as a legacy API that current @stylexjs/stylex no longer exports, which Devup UI keeps compiling as an extension, with its same-file restriction and override caveat. Refs #690 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This was referenced Nov 15, 2026
#975 now lets keys written after include() override the included ones; keep this PR's legacy-include framing and state the new override rule instead of the old 'only added' caveat. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Picks up #990, which fixes main's hook-order and WASM ABI count tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs cleanup for deep audit SX-13 / SX-14. Only the StyleX migration page (
apps/landing/src/app/(detail)/docs/migration/stylex/page.mdx) is changed. This page has no Korean version.styleResolution): added a "Style resolution" section. It states that Devup UI has no StyleXstyleResolutionoption and follows only StyleX's default policy (property-specificity), and what that means.props()/attrs()call, for the same property and condition, the later style wins.application-orderorlegacy-expand-shorthands, so it advises switching to longhands.include()): fixed the wording in "Value helpers" that presentedinclude()as a StyleX API. It now says it is a legacy API that Devup UI keeps compiling as an extension.stylex.d.tsof@stylexjs/stylex0.11.1 and 0.19.1 in the lockfile has noincludeexport. It remains only in Devup's@devup-ui/react/compat/stylexdeclarations.extract_style_from_stylex.rs,visit.rs):...stylex.include(ns.member)insidecreate()accepts only a namespace defined earlier in the same file, and prepends its classes to its own. Any other argument is a build error.includeis also marked separately as legacy.Behavior confirmed while writing the docs (no code changes)
Confirmed by running the latest WASM build directly.
stylex.props(s.btw, s.bw)(borderTopWidthvsborderWidth) oralignItemsvsplaceItems, the shorthand wins. This is because the stylesheet is sorted alphabetically by property name, and it differs from StyleX's default policy. WithmarginvsmarginTop, the longhand wins. The docs only say this case is not guaranteed.InFixed by fix(extractor): let later StyleX keys override an include() #975 (merged): keys written after{ ...stylex.include(s0.a), color: 'blue' }, red won by CSS order.include()now override the included ones at build time. After merging main, the docs state the new rule instead of the "not guaranteed" caveat.Overlapping PRs
migration/stylex/page.mdx; whichever merges second is reconciled with a merge commit.Test plan
bunx prettier --single-quote --no-semi --end-of-line auto --checkpasses (page.mdx)git diff --statthat line endings did not rewrite the whole file (14 lines added, 2 removed)codeExtractandgetCssof the latest WASM build요약
딥 오딧 SX-13 / SX-14 문서 정리입니다. StyleX 마이그레이션 페이지(
apps/landing/src/app/(detail)/docs/migration/stylex/page.mdx)만 수정했습니다. 이 페이지의 한국어판은 없습니다.styleResolution): "Style resolution" 섹션을 추가했습니다. Devup UI에는 StyleX의styleResolution옵션이 없고, StyleX 기본 정책(property-specificity)만 따른다는 점과 그 의미를 적었습니다.props()/attrs()호출 안에서 같은 속성과 조건이면 나중 스타일이 이깁니다.application-order와legacy-expand-shorthands에 해당하는 동작은 없으니 longhand로 바꾸라고 안내했습니다.include()): "Value helpers"에서include()를 StyleX API처럼 소개하던 문구를 고쳤습니다. 지금은 레거시 API이고, Devup UI는 확장으로 계속 컴파일한다고 적었습니다.@stylexjs/stylex0.11.1과 0.19.1의stylex.d.ts에includeexport가 없습니다. Devup의@devup-ui/react/compat/stylex선언에만 남아 있습니다.extract_style_from_stylex.rs,visit.rs):create()안의...stylex.include(ns.member)는 같은 파일에서 앞서 정의된 namespace만 받고, 그 클래스를 자기 클래스 앞에 붙입니다. 그 밖의 인자는 빌드 에러입니다.include를 레거시로 따로 표시했습니다.문서를 쓰다가 확인한 동작 (코드 변경 없음)
최신 WASM 빌드로 직접 돌려서 확인했습니다.
stylex.props(s.btw, s.bw)(borderTopWidth대borderWidth)나alignItems대placeItems에서는 shorthand가 이깁니다. 스타일시트가 속성 이름의 알파벳 순서로 정렬되기 때문이고, StyleX 기본 정책과 다릅니다.margin대marginTop에서는 longhand가 이깁니다. 문서에는 이 경우를 보장하지 않는다고만 적었습니다.는 fix(extractor): let later StyleX keys override an include() #975(병합됨)에서 고쳐졌습니다. 이제{ ...stylex.include(s0.a), color: 'blue' }에서 CSS 순서 때문에 red가 이기던 문제include()뒤에 쓴 키가 빌드 시점에 덮어씁니다. main을 병합하면서 문서도 "보장하지 않음" 대신 새 규칙을 적도록 바꿨습니다.겹치는 PR
migration/stylex/page.mdx를 고칩니다. 둘 중 나중에 머지되는 쪽에서 merge commit으로 맞춥니다.테스트 계획
bunx prettier --single-quote --no-semi --end-of-line auto --check통과 (page.mdx)git diff --stat으로 줄바꿈 때문에 파일 전체가 바뀌지 않았는지 확인 (14줄 추가, 2줄 삭제)codeExtract와getCss로 확인Refs #690
🤖 Generated with Claude Code