Repository navigation
test(e2e): poll the URL a localized refresh lands on - #982
Merged
Merged
Conversation
In Next dev mode the HTML refresh can abort the localized document before it loads, and waitForURL then fails with net::ERR_ABORTED. Poll the page URL instead, which survives an aborted navigation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#977에서 리다이렉트되는 locale 경로를
waitForURL(target, { waitUntil: 'load' })로 따라가게 했는데, Next 모드(Landing dev navigation tests (Next))에서는/ko의 HTML refresh가 한국어 문서를 load 전에 중단시킵니다. 이 경우waitForURL이net::ERR_ABORTED; maybe frame was detached?로 바로 실패합니다. #925, #957, #964, #978에서 같은 실패가 났습니다.waitForURL대신expect(page).toHaveURL(target)로 URL을 폴링합니다. 중단된 navigation에도 실패하지 않습니다.networkidle로 다시 열고 overlay·main·테마 토글·콘솔 오류 검사)은 그대로입니다.Test plan
landing-next-e2e(Next 모드)와 vinext 모드🤖 Generated with Claude Code