Repository navigation
Conversation
The ESLint plugin ships rules that run inside ESLint but never said which ESLint it supports; it now takes the range its typescript-eslint 8 dependency supports. The Next.js plugin accepted any @devup-ui/webpack-plugin as a peer while depending on the matching one; the peer now asks for a compatible version too. Refs #691 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remaining part of INF-23 (#691) that #940 left out of scope: two peer declarations still claimed more than the packages support.
@devup-ui/eslint-pluginhad noeslintpeer even though its rules run inside ESLint. It now declareseslint: ^8.57.0 || ^9.0.0 || ^10.0.0, the same range as itstypescript-eslint/@typescript-eslint/utils8 dependencies (checked in their installedpackage.json). The rules only usecontext.sourceCode.getScope(ESLint 8.37+), so 8.57 is not limited by our own code.@devup-ui/next-plugindepended on@devup-ui/webpack-plugin: workspace:^but its peer said*. The peer is nowworkspace:^too, whichbun pm packrewrites to^<version>the same way@devup-ui/componentsalready does for its@devup-ui/reactpeer.bun.lockupdates only the workspace peer specs (bun installreported no install changes).Changepack: Patch for both packages.
Test plan
bun install --ignore-scripts: lockfile changes only the two peer specs, "no changes" to installsgit diff --stat: 5 insertions / 2 deletions, no line-ending churn요약
#940에서 범위 밖으로 남겨 둔 INF-23(#691)의 나머지입니다. 두 peer 선언이 아직 실제 지원 범위보다 넓게 주장하고 있었습니다.
@devup-ui/eslint-plugin은 규칙이 ESLint 안에서 실행되는데도eslintpeer가 없었습니다. 이제eslint: ^8.57.0 || ^9.0.0 || ^10.0.0을 선언합니다. 의존하는typescript-eslint/@typescript-eslint/utils8의 범위와 같습니다(설치된package.json에서 확인). 규칙 코드는context.sourceCode.getScope(ESLint 8.37+)만 쓰므로 8.57 하한은 우리 코드가 아니라 typescript-eslint가 정합니다.@devup-ui/next-plugin은@devup-ui/webpack-plugin: workspace:^에 의존하면서 peer는*였습니다. peer도workspace:^로 바꿨습니다.@devup-ui/components의@devup-ui/reactpeer처럼bun pm pack이^<버전>으로 바꿔 줍니다.bun.lock은 워크스페이스 peer spec만 바뀝니다(bun install결과 설치 변경 없음).changepack: 두 패키지 모두 Patch.
테스트 계획
bun install --ignore-scripts: lockfile은 peer spec 두 줄만 바뀌고 설치 변경 없음git diff --stat: 5줄 추가 / 2줄 삭제, 라인 엔딩 churn 없음Refs #691
🤖 Generated with Claude Code