Skip to content

fix(plugins): declare the eslint peer and bound the webpack-plugin peer - #989

Open
owjs3901 wants to merge 2 commits into
mainfrom
fix/eslint-next-peer-ranges
Open

owjs3901 wants to merge 2 commits into
mainfrom
fix/eslint-next-peer-ranges

Conversation

@owjs3901

Copy link
Copy Markdown
Contributor

Summary

Remaining part of INF-23 (#691) that #940 left out of scope: two peer declarations still claimed more than the packages support.

  • @devup-ui/eslint-plugin had no eslint peer even though its rules run inside ESLint. It now declares eslint: ^8.57.0 || ^9.0.0 || ^10.0.0, the same range as its typescript-eslint / @typescript-eslint/utils 8 dependencies (checked in their installed package.json). The rules only use context.sourceCode.getScope (ESLint 8.37+), so 8.57 is not limited by our own code.
  • @devup-ui/next-plugin depended on @devup-ui/webpack-plugin: workspace:^ but its peer said *. The peer is now workspace:^ too, which bun pm pack rewrites to ^<version> the same way @devup-ui/components already does for its @devup-ui/react peer.
  • bun.lock updates only the workspace peer specs (bun install reported no install changes).

Changepack: Patch for both packages.

Test plan

  • bun install --ignore-scripts: lockfile changes only the two peer specs, "no changes" to installs
  • git diff --stat: 5 insertions / 2 deletions, no line-ending churn
  • CI green

요약

#940에서 범위 밖으로 남겨 둔 INF-23(#691)의 나머지입니다. 두 peer 선언이 아직 실제 지원 범위보다 넓게 주장하고 있었습니다.

  • @devup-ui/eslint-plugin은 규칙이 ESLint 안에서 실행되는데도 eslint peer가 없었습니다. 이제 eslint: ^8.57.0 || ^9.0.0 || ^10.0.0을 선언합니다. 의존하는 typescript-eslint / @typescript-eslint/utils 8의 범위와 같습니다(설치된 package.json에서 확인). 규칙 코드는 context.sourceCode.getScope(ESLint 8.37+)만 쓰므로 8.57 하한은 우리 코드가 아니라 typescript-eslint가 정합니다.
  • @devup-ui/next-plugin은 @devup-ui/webpack-plugin: workspace:^에 의존하면서 peer는 *였습니다. peer도 workspace:^로 바꿨습니다. @devup-ui/components의 @devup-ui/react peer처럼 bun pm pack이 ^<버전>으로 바꿔 줍니다.
  • bun.lock은 워크스페이스 peer spec만 바뀝니다(bun install 결과 설치 변경 없음).

changepack: 두 패키지 모두 Patch.

테스트 계획

  • bun install --ignore-scripts: lockfile은 peer spec 두 줄만 바뀌고 설치 변경 없음
  • git diff --stat: 5줄 추가 / 2줄 삭제, 라인 엔딩 churn 없음
  • CI 통과

Refs #691

🤖 Generated with Claude Code

The ESLint plugin ships rules that run inside ESLint but never said which
ESLint it supports; it now takes the range its typescript-eslint 8
dependency supports. The Next.js plugin accepted any @devup-ui/webpack-plugin
as a peer while depending on the matching one; the peer now asks for a
compatible version too.

Refs #691

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant