Repository navigation
test: fix main's hook-order and WASM ABI count tests broken by concurrent merges - #990
Merged
Merged
Conversation
owjs3901
added a commit
that referenced
this pull request
Nov 17, 2026
Picks up #990, which fixes main's hook-order and WASM ABI count tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
owjs3901
added a commit
that referenced
this pull request
Nov 17, 2026
Picks up #990, which fixes main's hook-order and WASM ABI count tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 of 6 tasks
owjs3901
added a commit
that referenced
this pull request
Nov 17, 2026
Pick up #990, which fixes main's rsbuild hook-order and WASM ABI count tests, so the publish job runs without those known failures. No conflicts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
owjs3901
added a commit
that referenced
this pull request
Nov 17, 2026
#963 keeps the CSS state of an engine session in CssState; carry the license banner there too (stored inverted so a fresh session keeps it on), so the test guard and session swaps restore it. #990 counts 46 validated argument positions; setLicenseBanner.enabled makes 47. Set the banner next to #962's project-root setup in Rsbuild and Bun, keep both README sections, and pass #928's inputs Set in #962's webpack project-root assertion. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main's
bun testfails on one test, so every open PR'spublishjob is red.order: 'post'transform for.mdxmodules.hooks.test.ts > registers the hooks a build runs, in the order it runs themgets one extratransform(source).removeFile.filename, so main validates 46 andtest:wasm-abifails. The count is now 46.Test plan
bun test packages/rsbuild-plugin/src/__tests__/hooks.test.ts: 5 passe2e/binding/validation-cases.mjson main yields 46 distinct positions요약
main의
bun test가 테스트 하나에서 실패해서, 열린 모든 PR의publishjob이 빨간색입니다..mdx모듈용order: 'post'transform을 추가하기 전에 Rsbuild 플러그인의 hook 등록 순서를 기록했습니다.hooks.test.ts > registers the hooks a build runs, in the order it runs them에transform(source)가 하나 더 나옵니다.removeFile.filename을 추가해 main은 46개를 검증합니다. 그래서test:wasm-abi가 실패합니다. 개수를 46으로 고쳤습니다.테스트 계획
bun test packages/rsbuild-plugin/src/__tests__/hooks.test.ts: 5개 통과e2e/binding/validation-cases.mjs에서 고유 위치가 46개임을 확인🤖 Generated with Claude Code