Skip to content

test: fix main's hook-order and WASM ABI count tests broken by concurrent merges - #990

Merged
owjs3901 merged 2 commits into
mainfrom
fix/rsbuild-hook-order-mdx
Nov 17, 2026
Merged

owjs3901 merged 2 commits into
mainfrom
fix/rsbuild-hook-order-mdx

Conversation

@owjs3901

@owjs3901 owjs3901 commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Main's bun test fails on one test, so every open PR's publish job is red.

Test plan

  • bun test packages/rsbuild-plugin/src/__tests__/hooks.test.ts: 5 pass
  • e2e/binding/validation-cases.mjs on main yields 46 distinct positions
  • CI

요약

main의 bun test가 테스트 하나에서 실패해서, 열린 모든 PR의 publish job이 빨간색입니다.

  • #957은 #960이 .mdx 모듈용 order: 'post' transform을 추가하기 전에 Rsbuild 플러그인의 hook 등록 순서를 기록했습니다.
  • 두 PR이 모두 병합되면서 main은 source transform을 두 개 등록하고, hooks.test.ts > registers the hooks a build runs, in the order it runs them에 transform(source)가 하나 더 나옵니다.
  • 이 PR은 테스트의 가짜 API에서 MDX transform을 따로 표시하고 마지막에 오도록 기대값을 고칩니다. 플러그인 코드는 바꾸지 않습니다.
  • 두 번째 원인: #952의 WASM ABI 검사는 검증하는 인자 위치를 45개로 세지만, 함께 병합된 #951이 removeFile.filename을 추가해 main은 46개를 검증합니다. 그래서 test:wasm-abi가 실패합니다. 개수를 46으로 고쳤습니다.

테스트 계획

  • bun test packages/rsbuild-plugin/src/__tests__/hooks.test.ts: 5개 통과
  • main의 e2e/binding/validation-cases.mjs에서 고유 위치가 46개임을 확인
  • CI

🤖 Generated with Claude Code

owjs3901 and others added 2 commits November 17, 2026 15:36
#957 recorded the hook order before #960 added an order: post transform
for .mdx modules. Both landed, so main registers two source transforms and
the test failed. Label the MDX transform and expect it last.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#952 counted 45 validated argument positions; #951, merged alongside it,
added removeFile.filename, so main validates 46 and the ABI gate failed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@owjs3901 owjs3901 changed the title test(rsbuild-plugin): expect the MDX post transform in the hook order test: fix main's hook-order and WASM ABI count tests broken by concurrent merges Nov 17, 2026
@owjs3901
owjs3901 merged commit 57d23f4 into main Nov 17, 2026
@owjs3901
owjs3901 deleted the fix/rsbuild-hook-order-mdx branch November 17, 2026 07:20
owjs3901 added a commit that referenced this pull request Nov 17, 2026
Picks up #990, which fixes main's hook-order and WASM ABI count tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
owjs3901 added a commit that referenced this pull request Nov 17, 2026
Picks up #990, which fixes main's hook-order and WASM ABI count tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
owjs3901 added a commit that referenced this pull request Nov 17, 2026
Pick up #990, which fixes main's rsbuild hook-order and WASM ABI count
tests, so the publish job runs without those known failures. No conflicts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
owjs3901 added a commit that referenced this pull request Nov 17, 2026
#963 keeps the CSS state of an engine session in CssState; carry the license
banner there too (stored inverted so a fresh session keeps it on), so the
test guard and session swaps restore it. #990 counts 46 validated argument
positions; setLicenseBanner.enabled makes 47. Set the banner next to #962's
project-root setup in Rsbuild and Bun, keep both README sections, and pass
#928's inputs Set in #962's webpack project-root assertion.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant