Skip to content

compiler: Refactor modulodimension handling in abridge_dim_names, avoiding repeated IET searches - #3052

Merged
mloubout merged 2 commits into
mainfrom
abridge_dim_names
Oct 26, 2026
Merged

mloubout merged 2 commits into
mainfrom
abridge_dim_names

Conversation

@EdCaunt

@EdCaunt EdCaunt commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Reduces overhead from the abridge_dim_names pass, which gets heavy when you have a large number of subdomains.

@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.29%. Comparing base (6d2ad82) to head (14cb20b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3052   +/-   ##
=======================================
  Coverage   84.28%   84.29%           
=======================================
  Files         258      258           
  Lines       57469    57470    +1     
  Branches     4914     4914           
=======================================
+ Hits        48439    48442    +3     
+ Misses       8206     8205    -1     
+ Partials      824      823    -1     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.48% <100.00%> (-0.01%) ⬇️
pytest-gpu-gcc- 78.93% <100.00%> (+<0.01%) ⬆️
pytest-gpu-icx- 78.84% <100.00%> (-0.01%) ⬇️
pytest-gpu-nvc-nvidiaX 69.18% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EdCaunt
EdCaunt requested a review from ZoeLeibowitz October 14, 2026 12:29
Comment thread devito/passes/iet/misc.py Outdated
@EdCaunt EdCaunt changed the title compiler: Cache modulodimensions in abridge_dim_names rather than repeatedly searching IET compiler: Refactor modulodimension handling in abridge_dim_names, avoiding repeated IET searches Oct 22, 2026
@EdCaunt
EdCaunt requested a review from mloubout October 22, 2026 10:10

@FabioLuporini FabioLuporini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sane

@mloubout
mloubout merged commit 2d37925 into main Oct 26, 2026
42 checks passed
@mloubout
mloubout deleted the abridge_dim_names branch October 26, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants