Repository navigation
ci: Test OpenMP offloading on Intel GPUs, with the Devito fixes it needs #3095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ggorman
wants to merge
7
commits into
main
Choose a base branch
from
intel-gpu-sycl-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
40a007b
compiler: Substitute the object of a method Call in Uxreplace
ggorman 1b23fef
arch: Query the memory of Intel GPUs through xpu-smi
ggorman 8affde8
docker: Take the Intel GPU runtime from the LTS 2523 channel
ggorman 2db0029
compiler: Stop passing -fopenmp-target-simd for Intel GPUs
ggorman 19f150e
ci: Run the GPU tests on Intel GPUs with OpenMP offloading
ggorman 8af16d5
ci: Build the Intel base images again, including gpu-icx
ggorman 141bd8d
docker: Let Intel MPI spawn processes in the Intel images
ggorman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1474,11 +1474,16 @@ def visit_Call(self, o): | |
| arguments.append(self._visit(i)) | ||
| else: | ||
| arguments.append(uxreplace(i, self.mapper)) | ||
| kwargs = {'arguments': arguments} | ||
| if o.base is not None: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That looks like a rebuild bug being bypassed here |
||
| # A call through an object, e.g. `obj.method(...)`, where `obj` | ||
| # may be in the mapper too | ||
| callee = uxreplace(o.callee, self.mapper) | ||
| if callee is not o.callee: | ||
| kwargs['name'] = callee | ||
| if o.retobj is not None: | ||
| retobj = uxreplace(o.retobj, self.mapper) | ||
| return reuse_if_unchanged(o, arguments=arguments, retobj=retobj) | ||
| else: | ||
| return reuse_if_unchanged(o, arguments=arguments) | ||
| kwargs['retobj'] = uxreplace(o.retobj, self.mapper) | ||
| return reuse_if_unchanged(o, **kwargs) | ||
|
|
||
| def visit_Lambda(self, o): | ||
| body = self._visit(o.body) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand why this needs to be separate from
name